Patches #671

Enhanced chat line editing

Added by terencehill 6 months ago. Updated 4 months ago.

Status:New Start:01/21/2010
Priority:Normal Due date:
Assigned to:- % Done:

100%

Category:Engine
Target version:2.5.5
Votes: 0

Description

With this patch it's possible to edit the chat line in the same way of the console line.
Though, not all of the console shortcuts/functions can be added because many ctrl-<key> shortcuts are bound to special chars.

I already did a patch for the nicks autocompletion code to work in the middle of the text (for now it still works but only at the end of the line, as before) but I'm not posting it together with this because it includes some minor bug fixes and improvements to the autocompletion code itself, I think it's better to post it separately later; however, with an explicit request of a developer I will merge that one too.

enhanced_chat_line_editing.patch (10.1 KB) terencehill, 01/26/2010 08:45 pm

History

Updated by Samual 6 months ago

So........... where's the patch?

Updated by terencehill 6 months ago

Damn! Forgot to upload it... here it is.
Btw, does it really matter if I upload the patch? Lately, no1 is reviewing any patch of mine... :(
Can you review this patch Samual? Or any1 else, if u want. Many of them aren't so complicated...

Updated by Samual 6 months ago

  • Status changed from New to Feedback

Tested it locally and it works very well --- Only problem I found was with using menu_cmd to do the rainbow colors, it started the cursor at the beginning of the line instead of at the end where it should be... Not a big problem, but it is to be desired for. Also: Name auto-completion sucks anyway, I don't use it due to it failing to work very well with names like mine which are full of characters and etc.

I vote for this to be committed :X

Updated by terencehill 5 months ago

  • Status changed from Feedback to New

I used to use sometimes that command too... Shouldn't that command work simply coloring the editing line only after it gets executed? If not, then sorry but I don't know the command u r talking about.

Name auto-completion works even there, once u know the correspondent character replacing the special character for autocompletion. Try using space, numbers, maybe other common symbols... Why does any1 know it? Because there are never enough available help commands.

Updated by terencehill 5 months ago

  • % Done changed from 80 to 100

... I meant here: #333

Updated by morfar 4 months ago

  • Target version changed from 2.5.3 to 2.5.5

Also available in: Atom PDF